udp errors should result in protocol.error_received, inconsistent with vanilla asyncio #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
requested changes
Aug 15, 2024
uvloop/handles/udp.pyx
Outdated
Comment on lines
257
to
260
| if isinstance(exc, OSError): | ||
| self._protocol.error_received(exc) | ||
| else: | ||
| self._fatal_error(exc, True) |
There was a problem hiding this comment.
I think this can be replaced by calling _on_sent() with the converted exception.
uvloop/handles/udp.pyx
Outdated
| @@ -244,14 +244,20 @@ cdef class UDPTransport(UVBaseTransport): | |||
| ctx.close() | |||
|
|
|||
| exc = convert_error(err) | |||
| self._fatal_error(exc, True) | |||
| if isinstance(exc, OSError): | |||
| self._protocol.error_received(exc) | |||
There was a problem hiding this comment.
This needs to be wrapped with run_in_context...(), see also the _on_sent() below.
jensbjorgensen
force-pushed
the
udp_protocol_error_not_fatal
branch
from
e55cebd to
dd53a3e
Compare
fantix
added a commit
that referenced
this pull request
Oct 14, 2024
Changes ======= * Add cleanup_socket param on create_unix_server() (#623) (by @fantix in d6114d2) Fixes ===== * Use cythonized SO_REUSEPORT rather than the unwrapped native one. (#609) (by @ptribble in 4083a94 for #550) * UDP errors should result in protocol.error_received (#601) (by @jensbjorgensen in 3c3bbef) * Updates for Cython3 (#587) (by @alan-brooks in 3fba9fa for #587) * Test with Python 3.13 (#610) (by @edgarrmondragon in fb5a139)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed a condition in production where a temporary network outage caused a UDP sendto to fail. In stock asyncio this would result in a call to error_received on the protocol object, but in uvloop this results in a fatal error that closes the transport. This is a rather nasty thing to happen since with vanilla asyncio when the transient network condition was resolved the transport could again be used, but with uvloop you would have to close the transport and repoen it.. See cpython source here:
https://github.com/python/cpython/blob/main/Lib/asyncio/selector_events.py#L1240
Sorry I don't have a script/fragment to reproduce the error, to do this you'd have to manipulate the networking stack such that the interface was not available after the transport was created. It's possible of course but I don't know of an easy way to do this.