Fix Connection class _copy_in private method #555
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found an issue in
Connection.copy_to_table()
method with a path-likesource
argument. The following code throws exceptionio.UnsupportedOperation: read
:It looks like
Connection._copy_in()
method opens file in a wrong mode (wb
instead ofrb
).So this fix:
rb
;Connection.copy_to_table()
method with a path-like source.