Latest version of ical.js and fix for EXDATE formats #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of EXDATE is different between google and exchange. This is causing the exclusion on recurring appointments not to work correctly and in some cases the mirror is unable to load the calendar
|
@roramirez It this ok with the work you're currently doing? |
|
Well ... I think we need approve only if include some tests. In the past we change something and affect the calendars, maybe was rrule or other related. I tested the change proposed (#839 (comment)) for set the ORDINAL_BASE lower date and the tests of this library they broke. I think not this way to fix this. |
|
@DutchDynamics Are you able to add tests? |
|
Closed due to inactivity. Feel free to reopen with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of EXDATE is different between google and exchange. This is causing the exclusion on recurring appointments not to work correctly and in some cases the mirror is unable to load the calendar