Translations issue #390
Translations issue #390
Conversation
Release of 2.0.3.
…ckTranslations if the two files are the same.
Merged latest "develop" branch
|
Hm, this isn't how I'd hoped it would all go - being a bit of a git novice is a pain. I just wanted to fork your "develop" branch and then submit my one change... |
|
Your Git work is ok. I received just the desired change. But the change itself does not do what needs to be done. More info here: 18ae08d#commitcomment-18511041 |
|
No, that's all be taken care of by the translator. Are you still experiencing issues? If so, please describe the issue in the original issue-post: #388 Thanks! |
|
It's all good - I think the author of the MMM-Voice-Control module wasn't using the singleton Translator correctly, as he was directly accessing Translator.translations instead of going through Translator.translate. This, of course, meant that in our case where the module loaded only the fallback translation then their code failed to retrieve the necessary values. I'm going to put a PR against their module, once I'm sure I've got it working properly :) |
|
Awesome! Thanks for your contribution! |
Regarding issue #388, I think this code handles the various permutations of translations/fallback translations and duplicate files.
If the
else ifisn't used then when the translationFile and translationsFallbackFile are the same, then MM actually loads only the translationsFallbackFile which can cause issues later on in modules that rely on having a translation entry present, and not a tranlsationFallback entry.