Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies, nail down node-ical version to 0.18.0 #3566

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Sep 28, 2024

  • node-ical use 0.18.0 instead of ^0.18.0 in package.json
  • cleanup package-lock.json

@khassel
Copy link
Collaborator Author

khassel commented Sep 28, 2024

The failed test is caused by the downgrade of node-ical, AFAIS we have to live with it (because we cannot upgrade node-ical before next release).

@khassel khassel requested a review from sdetweil September 28, 2024 19:24
@bugsounet
Copy link
Contributor

bugsounet commented Sep 28, 2024

You can tempory add allow-ghsas: GHSA-8hc4-vh64-cxmj in dep-review.yaml

      ....
      - name: "Dependency Review"
        uses: actions/dependency-review-action@v4
        with:
          allow-ghsas: GHSA-8hc4-vh64-cxmj

We used this kind of exception some time ago
In this case: Don't forget to notify it in the changelog so that we can check it during the next release of node-ical (in order to remove the exception)

@bugsounet
Copy link
Contributor

It's green now :)

@khassel
Copy link
Collaborator Author

khassel commented Sep 28, 2024

yes, thanks!

@sdetweil can you please review/merge?

@sdetweil
Copy link
Collaborator

looks good

@sdetweil sdetweil merged commit 719eca4 into MagicMirrorOrg:develop Sep 28, 2024
8 checks passed
@khassel khassel deleted the update_deps branch September 28, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants