add fix for sliceMultiDayEvents #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is this failure? test exceeded 30 minutes |
looks like github had problems, I restarted the jobs ... |
khassel
approved these changes
Sep 16, 2024
rejas
approved these changes
Sep 17, 2024
MarcLandis
added a commit
to MarcLandis/MagicMirror
that referenced
this pull request
Sep 24, 2024
This bug is caused by MagicMirrorOrg#3543. The calculation for midnight adds a day but for endDate we want the day to be subtracted again.
MarcLandis
added a commit
to MarcLandis/MagicMirror
that referenced
this pull request
Sep 24, 2024
This bug is caused by MagicMirrorOrg#3543. The calculation for midnight adds a day but for endDate we want the day to be subtracted again.
MarcLandis
added a commit
to MarcLandis/MagicMirror
that referenced
this pull request
Sep 25, 2024
This bug is caused by MagicMirrorOrg#3543. The calculation for midnight adds a day but for endDate we want the day to be subtracted again.
khassel
pushed a commit
that referenced
this pull request
Sep 25, 2024
This bug is caused by #3543. The calculation for midnight adds a day but for endDate we want the day to be subtracted again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sliceMultiDayEvents occasionally gets the number of events wrong and produces too many rows
Math.ceil() rounds up over 1.04 so we get an abnormal count
then the calcs for the midnight loop control used different moment() functions, producing different results
fixes #3542