Better fixes for #3291 and the underlying exdate issues

[jkriegshauser]

• Worked around several issues in the RRULE library that were causing deleted calender events to still show, some initial and recurring events to not show, and some event times to be off an hour. (one calendar test fails since today #3291)
• Renamed variables in calendarfetcherutils.js to be more clear about use of moment and js's Date class.
• Added calendar config option forceUseCurrentTime (default:false) which will ignore overridden Date.now in the config in order to keep some tests consistent.
• Added several unit tests for crossing DST in different timezones with excluded events.

[rejas]

so, whats this PR about actually ;-) ?

[jkriegshauser]

so, whats this PR about actually ;-) ?

It’s a WIP for better fixes for #3291 and the underlying exdate issues. I’m still seeing breakthrough events that have been excluded showing up. Stay tuned…

[sdetweil]

@jkriegshauser note that we changed rrule processors this release,(dragged in from node-ical) and are seeing weird results. skipped dates (null returned where date should be)

[jkriegshauser]

@jkriegshauser note that we changed rrule processors this release,(dragged in from node-ical) and are seeing weird results. skipped dates (null returned where date should be)

Odd, where is the null date being returned?

[sdetweil]

from the rrule.between in calendarfetcherutils.js

					Log.debug(`Search for recurring events between: ${pastLocal} and ${futureLocal}`);
					let dates = rule.between(pastLocal, futureLocal, true, limitFunction);   // <---- here 
					Log.debug(`Title: ${event.summary}, with dates: ${JSON.stringify(dates)}`); // you can see them in the debug output here 
					dates = dates.filter((d) => {      // this filter added in this release to remove null entries which cause crash
						if (JSON.stringify(d) === "null") return false;
						else return true;
					});

from a user with problem

[jkriegshauser]

from a user with problem

@sdetweil thanks, can you provide a link to the forum comment? The URL in the image doesn't seem to take me anywhere.

[sdetweil]

@jkriegshauser
see
https://forum.magicmirror.builders/topic/18363/calendar-module-missing-recurring-events-schedule-after-7pm-est

[jkriegshauser]

@rejas @sdetweil @khassel this is ready for review now. Sam, I kept the null filtering that you mentioned above, and I believe this will also address the problems mentioned in the forum post above.

[KristjanESPERANTO]

Thank you for your work! In case we need to look at the PR again later: Can you write in the initial comment what was changed? I think the text from the changelog would suffice.

[khassel]

Can you write in the initial comment what was changed? I think the text from the changelog would suffice.

I updated the description.

[jkriegshauser]

Ah I was just working on this.

…

On Mon, Jan 22, 2024 at 10:31 AM Karsten Hassel ***@***.***> wrote: Can you write in the initial comment what was changed? I think the text from the changelog would suffice. I updated the description. — Reply to this email directly, view it on GitHub <#3342 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM6MX66H5XALJPTGOWQVL3YP2WA7AVCNFSM6AAAAABBSLD2N2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGU3TKNBSG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[khassel]

Ah I was just working on this.

Sorry, you can update again ...

I'm fine with this PR, can this be merged? @sdetweil @rejas

[jkriegshauser]

Alright, should be gtg now

[jkriegshauser]

@rejas @sdetweil Can this be merged? I've been running it on two local instances for a week and had no issues. @khassel gave approval above. I just resolved conflicts

[rejas]

Sorry for delaying this longer than needed. Thanks for your work (and the insane amount of tests ;-)
Now only some doc updates are needed ;-)

[jkriegshauser]

Yep, planning on finishing those up when I get some time 😄

…

On Fri, Jan 26, 2024 at 10:59 PM Veeck ***@***.***> wrote: Sorry for delaying this longer than needed. Thanks for your work (and the insane amount of tests ;-) Now only some doc updates are needed ;-) — Reply to this email directly, view it on GitHub <#3342 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM6MX6GDBMU5EBDHKAU53TYQSQUZAVCNFSM6AAAAABBSLD2N2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGA2DGNRRHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>