Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updatenotification #3281

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

bugsounet
Copy link
Contributor

Sometime, pm2 jlist don't send an json reponse
Catch error if happen

@bugsounet
Copy link
Contributor Author

Note:

For me, best way is using pm2 library directly because with command line sometine we can have some pm2 warn (update warn for example) and it break response
but there is some moderate severity vulnerabilities with this library

@rejas: So, what can I do ?

@rejas
Copy link
Collaborator

rejas commented Dec 1, 2023

@bugsounet do you have a link to that vulnarbility?

@bugsounet
Copy link
Contributor Author

seams to be last current axios vulnerabilities

# npm audit report

axios  0.8.1 - 1.5.1
Severity: moderate
Axios Cross-Site Request Forgery Vulnerability - https://github.com/advisories/GHSA-wf5p-g6vw-rhxx
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/axios
  @pm2/js-api  *
  Depends on vulnerable versions of axios
  node_modules/@pm2/js-api
    pm2  >=3.0.0
    Depends on vulnerable versions of @pm2/js-api
    node_modules/pm2

3 moderate severity vulnerabilities

@rejas rejas merged commit 7485438 into MagicMirrorOrg:develop Dec 4, 2023
5 checks passed
@rejas
Copy link
Collaborator

rejas commented Dec 4, 2023

Well, axios is probably only fixable until node-ical gets updated (see #3278) (but maybe we can also force the update). Aynway, thx for the fix!

@bugsounet
Copy link
Contributor Author

I try to code (recode) it why pm2 library in draft and we see ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants