Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weathergov.js - new pull request against develop branch #3195

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

dgoth
Copy link
Contributor

@dgoth dgoth commented Sep 14, 2023

Fixes #3182

Fixed issue with probability of precipitation not showing up on hourly or daily forecast

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

Fixed issue with probability of precipitation not showing up on hourly or daily forecast
@dgoth
Copy link
Contributor Author

dgoth commented Sep 14, 2023

Ok I tried creating a new pull request.

Sorry never actually contributed to github before

@rejas
Copy link
Collaborator

rejas commented Sep 14, 2023

No worries, there's a first time for everyone :-)

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a CHANGELOG entry

modules/default/weather/providers/weathergov.js Outdated Show resolved Hide resolved
@rejas rejas merged commit a3c2e7b into MagicMirrorOrg:develop Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants