electron: add missing fullscreen option

[khassel]

follow up for #3187

@bugsounet can you please confirm that this now works for you?

[bugsounet]

works but ...

webPreferences: {
        fullscreen: false
      }

not work

[khassel]

  electronOptions: {
    width: 800,
    height: 600,
    fullscreen: false,
  },

works on my side

[bugsounet]

tested with your electronOptions: {} and don't work for me :/

[khassel]

strange, I used this in config.js:

/* MagicMirror       Config Sample
 *
 * By Michael Teeuw https://michaelteeuw.nl
 * MIT Licensed.
 *
 * For more information on how you can configure this file
 * see https://docs.magicmirror.builders/configuration/introduction.html
 * and https://docs.magicmirror.builders/modules/configuration.html
 */
let config = {

  electronOptions: {
    width: 800,
    height: 600,
    fullscreen: false,
  },

        address: "0.0.0.0",     // Address to listen on, can be:
                                                        // - "localhost", "127.0.0.1", "::1" to listen on loopback interface
                                                        // - another specific IPv4/6 to listen on a specific interface
                                                        // - "0.0.0.0", "::" to listen on any interface
                                                        // Default, when address config is left out or empty, is "localhost"
        port: 8080,
...

and it is 800x600 with taskbar, tested on a pi 4.

Did you test on a pi?

[bugsounet]

ah shit, it's me ... I have set it in webPreferences of electronOptions :/

So it's works :)

[bugsounet]

(we open the bets? e2e will work or not ??)

[khassel]

(we open the bets? e2e will work or not ??)

I hate the e2e tests ...

[bugsounet]

it will works PASS e2e tests/e2e/modules_position_spec.js