Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross UTC time fix #3175

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Cross UTC time fix #3175

merged 4 commits into from
Sep 8, 2023

Conversation

kenzal
Copy link
Contributor

@kenzal kenzal commented Sep 1, 2023

Update calendarfetcherutils.js to force recurrence date time to be the same as event datetime

I found an issue with one of my calendars displaying the wrong time for certain recurring events. Each event was set up by someone in a different timezone (Central European) than my own (Eastern US). I traced the issue back to the Rrule.between() method generating odd time portions under certain circumstances.

The fix I found was to set the UTC time portion of the recurrence datetime to be the same as the UTC time portion of the event start date.

This resolved the issues with the maladjusted event times, and had no effect on other event times. While there may be edge cases that are affected, I have been unable to locate any.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #3175 (b27f1e0) into develop (9d49196) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #3175      +/-   ##
===========================================
+ Coverage    26.15%   26.31%   +0.16%     
===========================================
  Files           53       53              
  Lines        11502    11505       +3     
===========================================
+ Hits          3008     3028      +20     
+ Misses        8494     8477      -17     
Files Changed Coverage Δ
modules/default/calendar/calendarfetcherutils.js 68.75% <100.00%> (+1.31%) ⬆️

... and 2 files with indirect coverage changes

@rejas rejas merged commit 79e99e1 into MagicMirrorOrg:develop Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants