fix calendar not showing events with the same name and start date but different calendar url

[Paranoid93]

I fixed the calendar module, which did not show calendar entries from different calendars that share the same name and start date.

My use case: We have each office days documented in each an own calendar. If both "Office" Calendar entries start at the same date just one was shown

Google Calendar (each Office event in an own calendar)

Before

After

[rejas]

Thx for the PR, unfortunately your test is failing. Can you have a look?

[Paranoid93]

I'm not that deep into the code. The better solution would probably be to compare some event ID. But for this use case the change should fix it

[rejas]

please run npm run lint:prettier and commit the changes to make the tests run again

[codecov-commenter]

Codecov Report

Merging #3166 (a9701fe) into develop (156db32) will increase coverage by 0.71%.
Report is 5 commits behind head on develop.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3166      +/-   ##
===========================================
+ Coverage    25.51%   26.23%   +0.71%     
===========================================
  Files           53       53              
  Lines        11501    11502       +1     
===========================================
+ Hits          2935     3018      +83     
+ Misses        8566     8484      -82     

Files Changed	Coverage Δ
modules/default/calendar/calendar.js	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

[rejas]

why move this?

[Paranoid93]

this is because otherwise the url isn't set yet for the comparison in listContainsEvent() in line 574.

But a better solution would be to compare events based on their UID. But for this I'd need more code (and javascript :D) knowledge

[rejas]

Sorry for the long delay until I commented more. Now I had the time to look at the code myself and I'd rather add a new config option hideDuplicate (which in your case you would set to true), use that as check before calling listContainsEvent and undo your change with the url comparison.
Reason for this: Checking if the url is the same is not really a check since that would mean you add an event from the same url: so why would you add the same url twice to the calendar anyway? If an event is duplicate it should mean that title, startdate are the same. A bonus to add would to also check for the same enddate (if present) becuase that is relevant over mutliple url calendars. I hope I make sense :-)