Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #3155

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Update dependencies #3155

merged 3 commits into from
Jul 16, 2023

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Jul 16, 2023

Takes #3153 (why does that always base against master despite the yaml configuring it against develop?) and updates othe rminor dependencies (not prettier v3 that will take a little time)

@rejas rejas changed the base branch from master to develop July 16, 2023 20:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #3155 (043eda5) into develop (1bd146f) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3155      +/-   ##
===========================================
+ Coverage    25.53%   25.62%   +0.08%     
===========================================
  Files           53       53              
  Lines        11492    11492              
===========================================
+ Hits          2935     2945      +10     
+ Misses        8557     8547      -10     

see 2 files with indirect coverage changes

dependabot bot and others added 3 commits July 16, 2023 23:08
@khassel
Copy link
Collaborator

khassel commented Jul 16, 2023

why is the test failing? You are working against develop and it complains to be against master ...

@khassel
Copy link
Collaborator

khassel commented Jul 16, 2023

o.k., rebasing solved this, so I will merge ...

@rejas
Copy link
Collaborator Author

rejas commented Jul 16, 2023

why is the test failing? You are working against develop and it complains to be against master ...

wondering myself. created the PR accidentally against master and edited it to be based against develop. maybe thats the thing that somehow isnt working....

@khassel khassel merged commit 49c72d8 into MagicMirrorOrg:develop Jul 16, 2023
@rejas rejas deleted the deps branch July 17, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants