Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor calendar methods into util class #3088

Merged
merged 13 commits into from
Apr 9, 2023

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Apr 8, 2023

Refactored some methods in calendar module:

  • move methods into own file
  • dont call shorten method from titelTransform because why? just call them after each other.
  • added tests for util methods
  • cleaned up other tests

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2023

Codecov Report

Merging #3088 (ff07366) into develop (dee3cd3) will decrease coverage by 1.88%.
The diff coverage is 66.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3088      +/-   ##
===========================================
- Coverage    27.90%   26.02%   -1.88%     
===========================================
  Files           52       53       +1     
  Lines        11574    11583       +9     
===========================================
- Hits          3230     3015     -215     
- Misses        8344     8568     +224     
Impacted Files Coverage Δ
modules/default/calendar/calendar.js 0.00% <0.00%> (-34.19%) ⬇️
modules/default/calendar/calendarfetcherutils.js 66.06% <66.06%> (ø)
modules/default/calendar/calendarutils.js 95.83% <96.00%> (+29.76%) ⬆️
modules/default/calendar/calendarfetcher.js 93.08% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas marked this pull request as ready for review April 8, 2023 20:49
@rejas rejas force-pushed the cleanup/calendar_utils branch 2 times, most recently from 4df662c to 1aee2d8 Compare April 9, 2023 06:42
@rejas rejas force-pushed the cleanup/calendar_utils branch from e641456 to 224653f Compare April 9, 2023 07:21
@rejas rejas requested a review from khassel April 9, 2023 09:20
@rejas
Copy link
Collaborator Author

rejas commented Apr 9, 2023

would then be ready to merge @khassel :-)

@khassel khassel merged commit 77f9c86 into MagicMirrorOrg:develop Apr 9, 2023
@rejas rejas deleted the cleanup/calendar_utils branch April 9, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants