Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and main.css to match new stylelint rules #3067

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Mar 19, 2023

On develop my css test failed because I was already on newest dependencies.

  • update deps
  • update main.css because of stylelint issue

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #3067 (ced77f7) into develop (ab0876f) will increase coverage by 4.49%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #3067      +/-   ##
===========================================
+ Coverage    23.05%   27.55%   +4.49%     
===========================================
  Files           52       52              
  Lines        11566    11566              
===========================================
+ Hits          2667     3187     +520     
+ Misses        8899     8379     -520     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, the css test works for me without an adjustment of the css file (with new dependencies). So I don't see any new rule.

But switching to inset is fine anyway, I think.

@khassel
Copy link
Collaborator Author

khassel commented Mar 20, 2023

strange, got this:

> stylelint 'css/main.css' 'fonts/*.css' 'modules/default/**/*.css' 'vendor/*.css' --config .stylelintrc.json
css/main.css
 177:3  ✖  Expected shorthand property "inset"  declaration-block-no-redundant-longhand-properties
1 problem (1 error, 0 warnings)

@KristjanESPERANTO
Copy link
Contributor

I should think once more before I write. I must have forgotten npm i 🤦. Now I get the message too.

@rejas rejas merged commit d5395ee into MagicMirrorOrg:develop Mar 20, 2023
@khassel khassel deleted the deps_css branch April 4, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants