Use template literals instead of string concatenation #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have used it inconsistently so far. Template literals are more modern and usually easier to read. https://eslint.org/docs/latest/rules/prefer-template
khassel
approved these changes
Mar 14, 2023
|
Good PR. I would vote for adding the rule to the eslint config and add one "// disable" exception to the line in the newsfeed module. That way we stay "modern" and can fix the line maybe later :-) |
rejas
requested changes
Mar 19, 2023
It is already included in "plugin:prettier/recommended".
|
I just did the following:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3066 +/- ##
===========================================
+ Coverage 23.02% 23.13% +0.10%
===========================================
Files 52 52
Lines 11582 11566 -16
===========================================
+ Hits 2667 2676 +9
+ Misses 8915 8890 -25
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have used it inconsistently till now. Template literals are more modern and easier to maintain in my opinion.
Because that's a large amount of changes, here's a way to reproduce it: I added the rule
"prefer-template": "error"to the.eslintrc.jsonand did an autofix. Since this caused a new problem in line 409 ofnewsfeed.js, I reversed it in that line and also removed the rule from the eslint config file.The rule is described here: https://eslint.org/docs/latest/rules/prefer-template
Note: I've played around with some other linter rules as well, and some seem to point to some specific, non-cosmetic, issues. But before I dive even deeper and then introduce even bigger and hardly understandable changes at once, I thought I'd start with this simple cosmetic rule.