Convert app-start/-stop callbacks to async/await #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #3035 +/- ##
===========================================
+ Coverage 22.95% 23.11% +0.16%
===========================================
Files 52 52
Lines 11567 11590 +23
===========================================
+ Hits 2655 2679 +24
+ Misses 8912 8911 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
force-pushed
the
misc/async_start_loadconfig
branch
5 times, most recently
from
0f03b66 to
c581a42
Compare
rejas
force-pushed
the
misc/async_start_loadconfig
branch
2 times, most recently
from
c6805aa to
9bbb6cf
Compare
rejas
force-pushed
the
misc/async_start_loadconfig
branch
2 times, most recently
from
567733a to
9c4fa24
Compare
rejas
changed the title
khassel
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #3027 and just touches the start/stop calls.