Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve electron tests (avoid errors in github workflows) #2977

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Dec 10, 2022

Fix electron tests failing sometimes in github workflow.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Merging #2977 (cb7aff7) into develop (eee289a) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2977      +/-   ##
===========================================
+ Coverage    22.75%   22.85%   +0.09%     
===========================================
  Files           51       51              
  Lines        10895    10887       -8     
===========================================
+ Hits          2479     2488       +9     
+ Misses        8416     8399      -17     
Impacted Files Coverage Δ
modules/default/compliments/compliments.js 0.00% <0.00%> (ø)
modules/default/updatenotification/node_helper.js 80.00% <0.00%> (+12.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@khassel
Copy link
Collaborator Author

khassel commented Dec 12, 2022

the failed codecov test is unrelated to this PR

@rejas
Copy link
Collaborator

rejas commented Dec 12, 2022

Rerunning fixed that. So this would be ready from your side?

@khassel
Copy link
Collaborator Author

khassel commented Dec 12, 2022

yes (did also a rerun so may a temporary problem).

@rejas rejas merged commit 2fec314 into MagicMirrorOrg:develop Dec 12, 2022
@khassel khassel deleted the electron-tests branch December 12, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants