Fixcal #2905
Merged
Fixcal #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejas
reviewed
Sep 6, 2022
| date = new Date(date.getTime() + Math.abs(24 * 60) * 60000); | ||
| // if the rrule byweekday WAS explicitly set , correct it | ||
| if (curEvent.rrule.origOptions.byweekday !== undefined) { | ||
| if (curEvent.rrule.origOptions.byweekday !== undefined) { |
There was a problem hiding this comment.
looks like a duplicate line?
There was a problem hiding this comment.
good catch, sent update
Codecov Report
@@ Coverage Diff @@
## develop #2905 +/- ##
========================================
Coverage 63.82% 63.82%
========================================
Files 9 9
Lines 293 293
========================================
Hits 187 187
Misses 106 106 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rrule and luxon miscalculate event day when byday is specified, but NOT without.
correct adjustment in calendarutils.js to adjust only when byday is specified
fixes: #2885