Fix problems with non latin fonds caused by updating to fontsource #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need feedback to this one. I had to substitue But there are no |
|
As long as it's supported by electron it seems fine by me. |
|
tested this with electron, but must be tested anyway by non-latin users ... |
|
During standard web-developmet, woff2 would indeed be preferred due to size improvements. But I guess here we can ignore that :-) |
rejas
approved these changes
Apr 5, 2022
nikow13
approved these changes
Apr 5, 2022
|
I merged this to see if this will cause issues. We can always revert if someone runs into issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2835