Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node-fetch 3.x #2750

Closed
wants to merge 12 commits into from
Closed

Upgrade to node-fetch 3.x #2750

wants to merge 12 commits into from

Conversation

KristjanESPERANTO
Copy link
Contributor

This is an attempt to tackle issue #2649.

Since node-fetch is converted into an ES module, a simple require statement no longer works.

@KristjanESPERANTO KristjanESPERANTO marked this pull request as draft December 26, 2021 16:35
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #2750 (348ddf3) into develop (528358f) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2750      +/-   ##
===========================================
+ Coverage    64.91%   65.26%   +0.35%     
===========================================
  Files            8        8              
  Lines          285      285              
===========================================
+ Hits           185      186       +1     
+ Misses         100       99       -1     
Impacted Files Coverage Δ
js/server.js 67.56% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528358f...348ddf3. Read the comment docs.

@KristjanESPERANTO
Copy link
Contributor Author

Since Node 18 will probably get native fetch support, I think that we don't need to continue this topic any further. See #2649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants