Support HTTPS Magicmirror (resubmit) #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichMich
reviewed
Feb 1, 2020
config/config.js.sample
Outdated
| @@ -21,6 +21,10 @@ var config = { | |||
| // or IPv4 range of 192.168.3.0 --> 192.168.3.15 use CIDR format : | |||
| // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.3.0/28"], | |||
|
|
|||
| useHttps: false, // Support HTTPS or not | |||
| httpsPrivateKey: "", // HTTPS Private Key path | |||
There was a problem hiding this comment.
I think it’s a good idea to explain that these variables are optional and only necessary if you want to use https. Agree?
There was a problem hiding this comment.
Yeah.... I will update it with below remark. Is that fine ?
useHttps: false, // Support HTTPS or not, default "false" will use HTTP
httpsPrivateKey: "", // HTTPS private key path, only require when useHttps is true
httpsCertificate: "", // HTTPS Certificate path, only require when useHttps is true
|
Yes, perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support HTTPS with issue ticket #1911 .
The original PR mark closed #1912
Thanks a lot !