fix: Issue #1798 - fixing recurrent calendar events crosstime DST #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MagicMirror into fix-timeshift-calendar
kurtzettel
reviewed
Jan 25, 2020
| @@ -26,6 +26,17 @@ exports.parseFile = function(filename){ | |||
|
|
|||
| var rrule = require('rrule').RRule | |||
|
|
|||
| function getLocaleISOString(date) { | |||
| var year = date.getFullYear().toString(10).padStart(4,'0'); | |||
| var month = date.getMonth().toString(10).padStart(2,'0'); | |||
There was a problem hiding this comment.
getMonth() returns a month between 0 and 11, not between 1 and 12 so this creates an invalid date.
There was a problem hiding this comment.
thanks for the catch. I just put up PR #1914 to address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1798 - converting to Local times for JS Date Objects before submitting to 'rrule' library. Issue appears to be in
Rrule.between()function where date and time are broken apart and then put back together, it looses reference to timezone with the UTC time passed.Fix - trick the function to thinking local time is UTC time and then convert back to UTC time after array of recurring events is returned.
Files impacted
Example:
Additional changes - Ran lint and inadvertently changed 8 other files.