update installer to handle non-pi and other issues #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add info on installer changes
|
Great PR! Thank you very much! |
roramirez
pushed a commit
to roramirez/MagicMirror
that referenced
this pull request
Jul 27, 2019
roramirez
added a commit
to roramirez/MagicMirror
that referenced
this pull request
Jul 27, 2019
MichMich
added a commit
that referenced
this pull request
Aug 3, 2019
installer: Remove comment lines added in PR #1715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated installer
give non-pi2+ users (pi0, odroid, jetson nano, mac, windows, ...) option to continue install
use current username vs hardcoded 'pi' to support non-pi install
check for npm installed. node install doesn't do npm anymore
check for mac as part of PM2 install, add install option string
update pm2 config with current username instead of hard coded 'pi'
check for screen saver config, "/etc/xdg/lxsession", bypass if not setup