Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sunrise/sunset to weathergov #1706

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Adding sunrise/sunset to weathergov #1706

merged 2 commits into from
Jun 18, 2019

Conversation

vincep5
Copy link
Contributor

@vincep5 vincep5 commented Jun 17, 2019

Please send your pull requests the develop branch.
Don't forget to add the change to CHANGELOG.md.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.
Thanks!

  • Does the pull request solve a related issue?
  • If so, can you reference the issue?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.

@vincep5 vincep5 changed the title Develop Adding sunrise/sunset to weathergov Jun 17, 2019
@vincep5
Copy link
Contributor Author

vincep5 commented Jun 17, 2019

Fix for #1705 Implemented sunrise/sunset for weathergov provider. Good idea which was taken from the recent code from the UKMetOffice.

@MichMich MichMich merged commit 37417fa into MagicMirrorOrg:develop Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants