Fading for dateheaders, fixed bug for fulldayevents #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included fading for dateheaders option Removed unnecessary switch statement in dateheaders option
- Fading for dateheaders timeFormat in Calendar [MagicMirrorOrg#1464](MagicMirrorOrg#1464) - Bug showing FullDayEvents one day too long in calendar fixe
Corrected formatting due to Travis CI errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included fading for dateheaders option (issue #1464)
Reworked the fading function, still included in the for loop. Now the fading opacity gets called twice, once for the date header and once for the event wrappers themselves
Removed unnecessary switch statement in dateheaders option
Fixed bug showing FullDayEvents one day too long by subtracting one Minute off FullDayEvents. Then they end at 23:59:59 on the respective ending day and not on 0:00:00 on the next day. Referring issue