Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize classes for table. #1314

Merged
merged 6 commits into from
Jun 12, 2018
Merged

Customize classes for table. #1314

merged 6 commits into from
Jun 12, 2018

Conversation

Ybbet
Copy link
Contributor

@Ybbet Ybbet commented Jun 11, 2018

MagicMirror offers helper classes in the main.css. Therefore, we give
the possibility to indicate the class that we want.

MagicMirror offers helper classes in the main.css. Therefore, we give
the possibility to indicate the class that we want.
@fewieden
Copy link
Contributor

  1. You should point your pull request to develop, instead of master (you can edit that on this page).
  2. You are missing a changelog entry
  3. You should put the new config options in the readme files of the module
  4. Not sure why you exclude that css file from git for everyone

@Ybbet Ybbet changed the base branch from master to develop June 11, 2018 11:59
@Ybbet
Copy link
Contributor Author

Ybbet commented Jun 11, 2018

Hi.
The changelog is added to the PR.

Ybbet added 2 commits June 11, 2018 16:41
Update of README for the new option.
Resolve format ith eslint
@MichMich
Copy link
Collaborator

The indents (mainly of the comments) seem to be a bit malformed.

@Ybbet
Copy link
Contributor Author

Ybbet commented Jun 11, 2018

I used the eslint format in the project. The last commit will resolved the indentation.
Sorry for all those errors. It's my first time with your project :-D
All checks have passed.

@MichMich
Copy link
Collaborator

Sorry, the indents are still messed up. It passes the linter, but it doesn't look very readable.

@Ybbet
Copy link
Contributor Author

Ybbet commented Jun 11, 2018

What is the size of the tab you use? It will be easier like that.

With a diff, here the orginal tabulations.
@Ybbet
Copy link
Contributor Author

Ybbet commented Jun 11, 2018

And now, with a diff between the original files and mine, the tabulation are back in life.

@MichMich MichMich merged commit dd79365 into MagicMirrorOrg:develop Jun 12, 2018
@MichMich
Copy link
Collaborator

Awesome. Thanks!

@Ybbet
Copy link
Contributor Author

Ybbet commented Jun 12, 2018

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants