-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature (for developers?): Update header with optional information #442
Comments
Yeah, this is something on my wishlist/todo list. Will probably add this feature next month. |
Of course a PR is welcome, but it depends on the implementation. I'm a little picky for the core changes. |
Well then start picking on #444 when you have time. Or you can just use this as a basis for your ideas. |
I've added this functionality. See: b2a7d35 Example code:
Let me know if this works for you. |
Actually, I think we want a I think if we have a |
Example: getHeader: function() {
return this.data.header + ' <span class="fa fa-refresh"></span> ' + this.lastUpdated;
} This one did not work for me inside a Although I am wondering why this post, says that for example |
Not sure. It should return a string. What error do you experience? |
If this really is an issue, I wouldn't mind moving to a dig container in stead of a header. Feel free to send a PR for this. Otherwise I can make an adjustment somewhere later this week. |
Never mind, my bad. I guess there must have been some other error. The When I originally implemented this, it appeared as if it did not resolve the html |
Good to hear. Looking forward to your module and see how you implemented it. |
I like headers for my modules, but at the same time they need additional space. Therefore I think it is useful to be able to add tiny bits of information to the header, which otherwise would need extra space in the module content.
An implementation example exists on my fork. I could create a clean pull request, with only the modifications regarding this
appendix
to the header (open for other name suggestions ;) ).For example we can show, when the last data was pulled in the backend, or how many contacts from the address book have been loaded, small hints if an error occurs, etc.
Maybe related losely to #236.
The text was updated successfully, but these errors were encountered: