Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateDom() should not fade header #236

Closed
paviro opened this issue Apr 24, 2016 · 5 comments
Closed

updateDom() should not fade header #236

paviro opened this issue Apr 24, 2016 · 5 comments

Comments

@paviro
Copy link
Contributor

paviro commented Apr 24, 2016

When a module updates it content the header fades as well as the content. Since a module can't change the header I think it should be static, would look better if only the content would change.

@MichMich
Copy link
Collaborator

That's because it's (currently) tied to the show and hide method.

@paviro
Copy link
Contributor Author

paviro commented Apr 24, 2016

Any chance this could be changed in the future?

@MichMich
Copy link
Collaborator

You're free to send a pull request. ;)

@paviro
Copy link
Contributor Author

paviro commented Apr 24, 2016

Will see if I find the time. Currently working on my modules.

@MichMich
Copy link
Collaborator

Since this now updates the header as well, this is the correct behavior. Therefor closing this issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants