Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron tests are broken #3676

Closed
khassel opened this issue Jan 2, 2025 · 3 comments
Closed

electron tests are broken #3676

khassel opened this issue Jan 2, 2025 · 3 comments
Assignees
@khassel
Labels
dependencies Pull requests that update a dependency file

Comments

@khassel
Copy link
Collaborator

khassel commented Jan 2, 2025

Before adding a PR I tested it on my fork. Without any changes related to electron and without any dependency updates all electron tests are failing.

Found a hint on the actions site:

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636

After changing the workflow back to ubuntu-22.04 the tests are working again.

Will provide this as hotfix.

I suspect in ubuntu-24.04 dependencies are missing needed by electron. We have enough time to solve the issue in 24.04 because 22.04 is supported for another 2 years.
@khassel khassel added the dependencies Pull requests that update a dependency file label Jan 2, 2025
@khassel khassel self-assigned this Jan 2, 2025
@sdetweil
Copy link
Collaborator

sdetweil commented Jan 2, 2025

where do you see the failures? I get notices for each build action, but haven't had any today

@khassel
Copy link
Collaborator Author

khassel commented Jan 2, 2025

e.g. https://github.com/khassel/MagicMirror/actions/runs/12589061748

maybe your account or MagicMirrorOrg account are still using 22.04 as latest, they do it step by step, but will be a question of time ...

@khassel khassel mentioned this issue Jan 2, 2025
Merged
rejas pushed a commit that referenced this issue Jan 3, 2025
@khassel
clientonly and wayland, hotfix electron tests (#3677)
0f6efac 
clientonly:
- did work only with xserver and `DISPLAY` env var
- now checks for `WAYLAND_DISPLAY` or `DISPLAY` env var before running
- if `WAYLAND_DISPLAY` is set now starts with wayland parameters

electron tests see #3676
@khassel
Copy link
Collaborator Author

khassel commented Jan 3, 2025 •
edited
Loading

I removed the "ready (coming with next release)" label because

  • the tests are unrelated to releases
  • we still have to get the electron tests running on ubuntu-24.04

@khassel khassel mentioned this issue Jan 4, 2025
Merged
rejas pushed a commit that referenced this issue Jan 5, 2025
@khassel
electron tests: fixes for running under new github image ubuntu-24.04 (…
8fdd865 
…#3680)

and replace xserver with labwc, fixes #3676
@khassel khassel closed this as completed Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khassel khassel

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rejas @sdetweil @khassel