Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

positions.js is created incorrectly on Windows #3662

Open
sdetweil opened this issue Dec 28, 2024 · 0 comments
Open

positions.js is created incorrectly on Windows #3662

sdetweil opened this issue Dec 28, 2024 · 0 comments
Assignees
@sdetweil
Labels
bug ready (coming with next release)

Comments

@sdetweil
Copy link
Collaborator

position.js is created on the fly, parsing index.html for the regions/positions used

the parse is done on lines created with split(os.EOL) ..oops file has linux line ends, won't be parsed on lins with os.EOL (\r\n on windows)
sdetweil added a commit to sdetweil/MagicMirror that referenced this issue Dec 28, 2024
@sdetweil
fix MagicMirrorOrg#3662 line parse on windows with linux line ends
4c62510
@sdetweil sdetweil self-assigned this Dec 28, 2024
@sdetweil sdetweil added the bug label Dec 28, 2024
khassel pushed a commit that referenced this issue Dec 28, 2024
@sdetweil
fix #3662 line parse on windows with linux line ends (#3663)
93a0c24 
line parse used os.EOL, which failed with linux line ends in index.html,
change to '\n'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdetweil sdetweil

Labels
bug ready (coming with next release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdetweil