Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather module (yr) hung on 'Loading ...' #3227

Closed
Justheretoreportanissue opened this issue Oct 11, 2023 · 10 comments · Fixed by #3248
Closed

Weather module (yr) hung on 'Loading ...' #3227

Justheretoreportanissue opened this issue Oct 11, 2023 · 10 comments · Fixed by #3248

Comments

@Justheretoreportanissue

Hi!

Using default weather module with provider 'yr' on MM v2.25.00

Is it just me or is there a problem with the api for 'sunrise'?

In the MM all 3 of my weather modules are stuck on 'Loading ...' since yesterday.

In the Console I can see the following errors:
Could not load weather data. SyntaxError: Unexpected non-whitespace character after JSON at position 4 (line 1 column 5) at JSON.parse (<anonymous>) at performWebRequest (utils.js:27:29)

Digging a bit deeper into the Chrome Console I find that the request for:
https://api.met.no/weatherapi/sunrise/2.3/sun?lat=<XX.XXXX>&lon=<YY.YYYY>&date=2023-10-11&offset=%2B02%3A00

Gives a response of:
404 Not Found
The specified version number is not supported by this product

I get the same error when trying the above with curl in a terminal on the MM server.

Apparently the api for 'locationforecast' still works.

Running this with curl in a terminal produces nice json output:
https://api.met.no/weatherapi/locationforecast/2.0/complete?&altitude=1&lat=<XX.XXXX>&lon=<YY.YYYY>

*) Yes, I have exchanged my 'lat' and 'lon' with placeholders.

Regards,

/Jonas...

@Justheretoreportanissue
Copy link
Author

Answering myself here...

Could it be that v2.3 of this api is no longer supported and that v3.0 should be used instead?

https://api.met.no/weatherapi/sunrise/3.0/sun?lat=<XX.XXXX>&lon=<YY.YYYY>&date=2023-10-11&offset=%2B02%3A00

Regards,

/Jonas...

@khassel khassel added the bug label Oct 11, 2023
@khassel
Copy link
Collaborator

khassel commented Oct 11, 2023

They are fast with their api changes ...

We should introduce apiVersionSunrise and apiVersionLocationforecast so users can change this in config.js.

Could it be that v2.3 of this api is no longer supported and that v3.0 should be used instead?
https://api.met.no/weatherapi/sunrise/3.0/sun?lat=<XX.XXXX>&lon=<YY.YYYY>&date=2023-10-11&offset=%2B02%3A00

Did you test this statement? Is the output valid json?

If so you could change the version from 2.0 to 3.0 in this line and test if the module works with 3.0

@Justheretoreportanissue
Copy link
Author

Was about to get back here and confirm it working.

Have already gone through the code and made that exact change.

Yes, confirmed working after the change. No more problem with 'Loading ...'

Regards,

/Jonas...

@rejas
Copy link
Collaborator

rejas commented Oct 12, 2023

Thx for the report. Do you want to create a PR for this fix too?

@Justheretoreportanissue
Copy link
Author

Sorry, not that smart with GH, just able to read and correct code.

Please feel free to make the correction and sort it out. I just do not have that skillset (yet).

/Jonas...

@rejas
Copy link
Collaborator

rejas commented Oct 12, 2023

Ok, will create a PR later for this.

@johnhelt
Copy link

The default values for the forecastApiVersion is 3.0 by default, but it should be 2.0.

@rejas
Copy link
Collaborator

rejas commented Oct 23, 2023

Is 2.0 working?

@johnhelt
Copy link

Yes for the forecast api.

@rejas
Copy link
Collaborator

rejas commented Oct 23, 2023

Thx for the info!

khassel pushed a commit that referenced this issue Oct 23, 2023
MichMich added a commit that referenced this issue Jan 1, 2024
## [2.26.0] - 01-01-2024

Thanks to: @bnitkin, @bugsounet, @dependabot, @jkriegshauser,
@kaennchenstruggle, @KristjanESPERANTO and @Ybbet.

Special thanks to @khassel, @rejas and @sdetweil for taking over most
(if not all) of the work on this release as project collaborators. This
version would not be there without their effort. Thank you guys! You are
awesome!

This release also marks the latest release by Michael Teeuw. For more
info, please read the following post: [A New Chapter for MagicMirror:
The Community Takes the
Lead](https://forum.magicmirror.builders/topic/18329/a-new-chapter-for-magicmirror-the-community-takes-the-lead).

### Added

- Added update notification updater (for 3rd party modules)
- Added node 21 to the test matrix
- Added transform object to calendar:customEvents
- Added ESLint rules for jest (including jest/expect-expect and
jest/no-done-callback)

### Removed

- Removed Codecov workflow (not working anymore, other workflow
required) (#3107)
- Removed titleReplace from calendar, replaced + extended by
customEvents (backward compatibility included) (#3249)
- Removed failing unit test (#3254)
- Removed some unused variables

### Updated

- Update electron to v27 and update other dependencies as well as github
actions
- Update newsfeed: Use `html-to-text` instead of regex for transform
description
- Review ESLint config (#3269)
- Updated dependencies
- Clock module: optionally display current moon phase in addition to
rise/set times
- electron is now per default started without gpu, if needed it must be
enabled with new env var `ELECTRON_ENABLE_GPU=1` on startup (#3226)
- Replace prettier by stylistic in ESLint config to lint JavaScript (and
disable some rules for `config/config.js*` files)
- Update node-ical to v0.17.1 and fix tests

### Fixed

- Avoid fade out/in on updateDom when many calendars are used
- Fix the option eventClass on customEvents.
- Fix yr API version in locationforecast and sunrise call (#3227)
- Fix cloneObject() function to respect RegExp (#3237)
- Fix newsfeed module for feeds using "a10:updated" tag (#3238)
- Fix issue template (#3167)
- Fix #3256 filter out bad results from rrule.between
- Fix calendar events sometimes not respecting deleted events (#3250)
- Fix electron loadurl locally on Windows when address "0.0.0.0" (#2550)
- Fix updatanotification (update_helper.js): catch error if reponse is
not an JSON format (check PM2)
- Fix missing typeof in calendar module
- Fix style issues after prettier update
- Fix calendar test (#3291) by moving "Exdate check" from e2e to
electron to run on a Thursday
- Fix calendar config params `fetchInterval` and `excludedEvents` were
never used from single calendar config (#3297)
- Fix MM_PORT variable not used in electron and allow full path for
MM_CONFIG_FILE variable (#3302)

---------

Signed-off-by: naveen <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Karsten Hassel <[email protected]>
Co-authored-by: Malte Hallström <[email protected]>
Co-authored-by: Veeck <[email protected]>
Co-authored-by: veeck <[email protected]>
Co-authored-by: dWoolridge <[email protected]>
Co-authored-by: Johan <[email protected]>
Co-authored-by: Dario Mratovich <[email protected]>
Co-authored-by: Dario Mratovich <[email protected]>
Co-authored-by: Magnus <[email protected]>
Co-authored-by: Naveen <[email protected]>
Co-authored-by: buxxi <[email protected]>
Co-authored-by: Thomas Hirschberger <[email protected]>
Co-authored-by: Kristjan ESPERANTO <[email protected]>
Co-authored-by: Andrés Vanegas Jiménez <[email protected]>
Co-authored-by: Dave Child <[email protected]>
Co-authored-by: grenagit <[email protected]>
Co-authored-by: Grena <[email protected]>
Co-authored-by: Magnus Marthinsen <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Piotr Rajnisz <[email protected]>
Co-authored-by: Suthep Yonphimai <[email protected]>
Co-authored-by: CarJem Generations (Carter Wallace) <[email protected]>
Co-authored-by: Nicholas Fogal <[email protected]>
Co-authored-by: JakeBinney <[email protected]>
Co-authored-by: OWL4C <[email protected]>
Co-authored-by: Oscar Björkman <[email protected]>
Co-authored-by: Ismar Slomic <[email protected]>
Co-authored-by: Jørgen Veum-Wahlberg <[email protected]>
Co-authored-by: Eddie Hung <[email protected]>
Co-authored-by: Bugsounet - Cédric <[email protected]>
Co-authored-by: bugsounet <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Knapoc <[email protected]>
Co-authored-by: sam detweiler <[email protected]>
Co-authored-by: veeck <[email protected]>
Co-authored-by: Paranoid93 <[email protected]>
Co-authored-by: NolanKingdon <[email protected]>
Co-authored-by: J. Kenzal Hunter <[email protected]>
Co-authored-by: Teddy <[email protected]>
Co-authored-by: TeddyStarinvest <[email protected]>
Co-authored-by: martingron <[email protected]>
Co-authored-by: dgoth <[email protected]>
Co-authored-by: kaennchenstruggle <[email protected]>
Co-authored-by: jkriegshauser <[email protected]>
Co-authored-by: Ben Nitkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants