Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather module: add feature "showOutdoorTemperature" #3126

Closed
Coernel82 opened this issue Jun 17, 2023 · 3 comments
Closed

Weather module: add feature "showOutdoorTemperature" #3126

Coernel82 opened this issue Jun 17, 2023 · 3 comments

Comments

@Coernel82
Copy link

The module already has the option to display the notification of INDOOR_TEMPERATURE by other modules. People also have outdoor sensors. So adding the functioncality for showOutdoorTemperature (assuming the notification OUTDOOR_TEMPERATURE is already existant.
This could then optionally replace or complement the outdoor temperature received by the weather provider.

After this https://github.com/splattner/MMM-MQTT-Notification could be used to send the notificaton if using MQTT.

@rejas rejas changed the title enhancement: add feature "showOutdoorTemperature" Weather module: add feature "showOutdoorTemperature" Jun 17, 2023
@rejas
Copy link
Collaborator

rejas commented Jun 17, 2023

Sounds like a useful feature indeed. Do you want to work on it? or would you want help with that?

@Coernel82
Copy link
Author

I am a total noob. I can program some minimalistic PHP and CPP for Arduino. As much as I would love to this is far too complex for me I guess.
However I will have a look at the code and report back if I might be able to do it!

@Coernel82
Copy link
Author

I had the promised look at the code and it seems as this could be established without to much hassle as the code already exists for the other broadcast variable.
For some reasons however I decided not to proceed this further

  • first of all I am really a noob so even though the task appears to be easy I might make mistakes and spend a long time correcting them. This time I currently lack of
  • after more research I found out there is already a MMM MQTT weather module available getting a ton of MQTT readings such as wind, moisture, lightlevel and much more. Maybe there should be some cooperation? Have a look at https://github.com/spitzlbergerj/MMM-Currentweather-MQTT

Thanks for your understanding!

rejas added a commit that referenced this issue Sep 8, 2023
Fixes #3126 

Added the option `allowOverrideNotification` to `weather.js`. This
allows the module to receive the `CURRENT_WEATHER_OVERRIDE`
notification. The expected payload for this notification is a
full/partial `weatherObject` that is used to supplement/replace the
existing `weatherObject` returned by whichever weather provider is in
use.

No visual changes.

First time contributing - let me know if I've missed something
:slightly_smiling_face:

---------

Co-authored-by: veeck <[email protected]>
@khassel khassel closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants