-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather module: add feature "showOutdoorTemperature" #3126
Comments
Sounds like a useful feature indeed. Do you want to work on it? or would you want help with that? |
I am a total noob. I can program some minimalistic PHP and CPP for Arduino. As much as I would love to this is far too complex for me I guess. |
I had the promised look at the code and it seems as this could be established without to much hassle as the code already exists for the other broadcast variable.
Thanks for your understanding! |
Fixes #3126 Added the option `allowOverrideNotification` to `weather.js`. This allows the module to receive the `CURRENT_WEATHER_OVERRIDE` notification. The expected payload for this notification is a full/partial `weatherObject` that is used to supplement/replace the existing `weatherObject` returned by whichever weather provider is in use. No visual changes. First time contributing - let me know if I've missed something :slightly_smiling_face: --------- Co-authored-by: veeck <[email protected]>
The module already has the option to display the notification of
INDOOR_TEMPERATURE
by other modules. People also have outdoor sensors. So adding the functioncality forshowOutdoorTemperature
(assuming the notificationOUTDOOR_TEMPERATURE
is already existant.This could then optionally replace or complement the outdoor temperature received by the weather provider.
After this https://github.com/splattner/MMM-MQTT-Notification could be used to send the notificaton if using MQTT.
The text was updated successfully, but these errors were encountered: