Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock in analog mode doesn't show date #3100

Closed
jorgenwahlberg opened this issue May 7, 2023 · 2 comments · Fixed by #3101
Closed

Clock in analog mode doesn't show date #3100

jorgenwahlberg opened this issue May 7, 2023 · 2 comments · Fixed by #3101

Comments

@jorgenwahlberg
Copy link
Contributor

When using the clock module and setting displayType to "analog" and showDate to true, date is no longer shown. In earlier releases, it did.

This bug can be reproduced by setting up a the module like this:

                {
                        module: "clock",
                        position: "top_left",
                        config: {
                                displayType: "analog",
                                analogSize: "360px",
                                analogPlacement: "bottom",
                                analogFace: "face-003",
                                analogShowDate: "top",
                                showDate: true,
                                displaySeconds: true,
                        }
                }

When setting displayType to "both" or "digital", the date is shown.

@rejas
Copy link
Collaborator

rejas commented May 8, 2023

Thanks for the report (and the PR)! Will discuss it in the PR.

rejas added a commit that referenced this issue May 19, 2023
Adding date to the clock module when displayType is "analog" and
"showDate" is true. The setting in analogShowDate is respected.

Fixes #3100

---------

Co-authored-by: Michael Teeuw <[email protected]>
Co-authored-by: Veeck <[email protected]>
@khassel
Copy link
Collaborator

khassel commented Jul 1, 2023

fixed with new release v2.24.0

@khassel khassel closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants