Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling CLOCK_SECOND notification #3056

Closed
slametps opened this issue Mar 2, 2023 · 4 comments · Fixed by #3059
Closed

disabling CLOCK_SECOND notification #3056

slametps opened this issue Mar 2, 2023 · 4 comments · Fixed by #3059

Comments

@slametps
Copy link
Contributor

slametps commented Mar 2, 2023

is there a way to NOT send NOTIFICATION CLOCK_SECOND every single second (flooding) with displaySeconds = true in CLOCK module?

@sdetweil
Copy link
Collaborator

sdetweil commented Mar 2, 2023

no.. but you could add another option and submit a pr

sendNotification:true,

if (this.config.sendNotification)

in config.js for clock
sendNotification:false

@sdetweil
Copy link
Collaborator

sdetweil commented Mar 2, 2023

u can also filter in the dev console
using a part of the module name u care about in the filter field

@ghost
Copy link

ghost commented Mar 3, 2023

comment this line in clock.js
self.sendNotification("CLOCK_SECOND", self.second);
like this one
// self.sendNotification("CLOCK_SECOND", self.second);

@slametps
Copy link
Contributor Author

slametps commented Mar 6, 2023

comment this line in clock.js self.sendNotification("CLOCK_SECOND", self.second); like this one // self.sendNotification("CLOCK_SECOND", self.second);

Previously, I did it the hard way the same as you suggest.
I just not OK with every second sending notification causing flooding (resource consume). Still OK with CLOCK_MINUTE.
And I did not want to disable any other notifications, CLOCK_SECOND only. But I can't find the polite way to to this.

khassel pushed a commit that referenced this issue Apr 1, 2023
Fixes #3056 

One question here would be if the default for this new option should be
true or false.

True: keeps the current behaviour, nobody needs to change his config if
they rely on this option

False: keeps the clock notifications quiet, doesnt waste time/resources,
keeps the noise low

Maybe the original author @cybex-dev can weigh in on this, and why he
added this notification.

---------

Co-authored-by: veeck <[email protected]>
rejas added a commit to rejas/MagicMirror that referenced this issue Apr 1, 2023
Fixes MagicMirrorOrg#3056 

One question here would be if the default for this new option should be
true or false.

True: keeps the current behaviour, nobody needs to change his config if
they rely on this option

False: keeps the clock notifications quiet, doesnt waste time/resources,
keeps the noise low

Maybe the original author @cybex-dev can weigh in on this, and why he
added this notification.

---------

Co-authored-by: veeck <[email protected]>
MichMich added a commit that referenced this issue Apr 4, 2023
## [2.23.0] - 2023-04-04

Thanks to: @angeldeejay, @buxxi, @CarJem, @dariom, @DaveChild, @dWoolridge, @grenagit, @Hirschberger, @KristjanESPERANTO, @MagMar94, @naveensrinivasan, @nfogal, @psieg, @rajniszp, @retroflex, @SkySails and @tomzt.

Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not all) of the work on this release as project collaborators. This version would not be there without their effort. Thank you guys! You are awesome!

### Added

- Added increments for hourly forecasts in weather module (#2996)
- Added tests for hourly weather forecast
- Added possibility to ignore MagicMirror repo in updatenotification module
- Added Pirate Weather as new weather provider (#3005)
- Added possibility to use your own templates in Alert module
- Added error message if `<modulename>.js` file is missing in module folder to get a hint in the logs (#2403)
- Added possibility to use environment variables in `config.js` (#1756)
- Added option `pastDaysCount` to default calendar module to control of how many days past events should be displayed
- Added thai language to alert module
- Added option `sendNotifications` in clock module (#3056)

### Removed

- Removed darksky weather provider
- Removed unneeded (and unwanted) '.' after the year in calendar repeatingCountTitle (#2896)

### Updated

- Use develop as target branch for dependabot
- Update issue template, contributing doc and sample config
- The weather modules clearly separates precipitation amount and probability (risk of rain/snow)
  - This requires all providers that only supports probability to change the config from `showPrecipitationAmount` to `showPrecipitationProbability`.
- Update tests for weather and calendar module
- Changed updatenotification module for MagicMirror repo only: Send only notifications for `master` if there is a tag on a newer commit
- Update dates in Calendar widgets every minute
- Cleanup jest coverage for patches
- Update `stylelint` dependencies, switch to `stylelint-config-standard` and handle `stylelint` issues, update `main.css` matching new rules
- Update Eslint config, add new rule and handle issue
- Convert lots of callbacks to async/await
- Revise require imports (#3071 and #3072)

### Fixed

- Fix wrong day labels in envcanada forecast (#2987)
- Fix for missing default class name prefix for customEvents in calendar
- Fix electron flashing white screen on startup (#1919)
- Fix weathergov provider hourly forecast (#3008)
- Fix message display with HTML code into alert module (#2828)
- Fix typo in french translation
- Yr wind direction is no longer inverted
- Fix async node_helper stopping electron start (#2487)
- The wind direction arrow now points in the direction the wind is flowing, not into the wind (#3019)
- Fix precipitation css styles and rounding value
- Fix wrong vertical alignment of calendar title column when wrapEvents is true (#3053)
- Fix empty news feed stopping the reload forever
- Fix e2e tests (failed after async changes) by running calendar and newsfeed tests last
- Lint: Use template literals instead of string concatenation
- Fix default alert module to render HTML for title and message
- Fix Open-Meteo wind speed units
@rejas rejas closed this as completed Apr 4, 2023
@rejas rejas added this to the 2.23 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants