Skip to content

Commit

Permalink
removed unneeded (and unwanted) '.' in calendar (#3003)
Browse files Browse the repository at this point in the history
- removed unneeded (and unwanted) '.' after the year in calendar
repeatingCountTitle (fixes #2896)
- update Collaboration.md
  • Loading branch information
khassel authored Jan 14, 2023
1 parent 29e3ec0 commit d2327d3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ _This release is scheduled to be released on 2023-04-01._
### Removed

- Removed darksky weather provider
- Removed unneeded (and unwanted) '.' after the year in calendar repeatingCountTitle (#2896)

### Updated

Expand Down
5 changes: 5 additions & 0 deletions Collaboration.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,13 @@ This document describes how collaborators of this repository should work togethe
- never merge your own PR's
- never merge without someone having approved (approving and merging from same person is allowed)
- wait for all approvals requested (or the author decides something different in the comments)
- never merge to `master`, except for releases (because of update notification)

## Issues

- "real" Issues are closed if the problem is solved and the fix is released
- unrelated Issues (e.g. related to a foreign module) are closed immediately with a comment to open an issue in the module repository or to discuss this further in the forum or discord

## Releases

- are done by @MichMich only
2 changes: 1 addition & 1 deletion modules/default/calendar/calendar.js
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ Module.register("calendar", {
const thisYear = new Date(parseInt(event.startDate)).getFullYear(),
yearDiff = thisYear - event.firstYear;

repeatingCountTitle = ", " + yearDiff + ". " + repeatingCountTitle;
repeatingCountTitle = ", " + yearDiff + repeatingCountTitle;
}
}

Expand Down

0 comments on commit d2327d3

Please sign in to comment.