Add tests for some weather utils (#3103)

Co-authored-by: veeck <[email protected]>
MagicMirrorOrg · May 15, 2023 · 432d900 · 432d900
1 parent 83315f1
commit 432d900
Show file tree

Hide file tree

Showing 7 changed files with 227 additions and 357 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -52,6 +52,7 @@ Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not al
 - Added option `pastDaysCount` to default calendar module to control of how many days past events should be displayed
 - Added thai language to alert module
 - Added option `sendNotifications` in clock module (#3056)
+- Added tests for some weather utils
 
 ### Removed
 

diff --git a/modules/default/weather/providers/openweathermap.js b/modules/default/weather/providers/openweathermap.js
@@ -434,6 +434,7 @@ WeatherProvider.register("openweathermap", {
 		} else if (this.firstEvent && this.firstEvent.location) {
 			params += `q=${this.firstEvent.location}`;
 		} else {
+			// TODO hide doesnt exist!
 			this.hide(this.config.animationSpeed, { lockString: this.identifier });
 			return;
 		}

diff --git a/modules/default/weather/weatherutils.js b/modules/default/weather/weatherutils.js
@@ -30,6 +30,8 @@ const WeatherUtils = {
 	 * @returns {string} - A string with tha value and a unit postfix.
 	 */
 	convertPrecipitationUnit(value, valueUnit, outputUnit) {
+		if (valueUnit === "%") return `${value.toFixed(0)} ${valueUnit}`;
+
 		let convertedValue = value;
 		let conversionUnit = valueUnit;
 		if (outputUnit === "imperial") {
@@ -40,8 +42,6 @@ const WeatherUtils = {
 			conversionUnit = valueUnit ? valueUnit : "mm";
 		}
 
-		if (valueUnit === "%") return `${convertedValue.toFixed(0)} ${conversionUnit}`;
-
 		return `${convertedValue.toFixed(2)} ${conversionUnit}`;
 	},