Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos, add doc for calendar FullDateEnd format usage, add new env for fetch timeout #277

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

sdetweil
Copy link
Collaborator

update doc for positions, a typo
add doc for FullDateEndFormat usage with showEnd:true
add new env variable for fetchTimeout

@@ -73,7 +73,8 @@ are:
| Environment Variable Name | Use |
| ------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| MM_CONFIG_FILE | This specifies an alternate configuration file for the system. This is useful when running multiple mirrors on the same device. This does not work with the template option below. NOTE: this file **_MUST_** be located in a directory within the MagicMirror directory. Ideally, place any config file in the config subdirectory. |
| MM_PORT | This specifies an alternate TCPIP port, overriding "port" item within the config file. This is useful for testing to see if the product will run using another port. |
| MM_PORT | This specifies an alternate TCPIP port, overriding "port" item within the config file. This is useful for testing to see if the product will run using another port.
| mmFetchTimeout | time in milliseconds for fetch timeout. default (30000) <br><br>this value can be used the adjust the nodejs fetch function timeout value (default 10 seconds) for all node_helper modules that use fetch() |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "to adjust", some double spaces should be removed "10__seconds)__"

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took the liberty to update the PR

@rejas rejas merged commit 9f756ef into MagicMirrorOrg:develop Dec 30, 2024
khassel added a commit that referenced this pull request Jan 1, 2025
* weather.md: update for recent changes (#230)

* add updates feature configuration (#234)

* Update calendar.md (#236)

* updateOnFetch feature Docs (#235)

* Minor changes (#238)

* Minor changes
- wording
- Magic Mirror -> MagicMirror
- format

* sh -> shell

* Update compliments docs page (#242)

Add documentation for the specialDayUnique config option

* Cleanup formatting (#247)

* bump prettier

* run prettier

* UK Met Office Documentation Fix (#253)

* Update weather.md

Updated documentation for MetOffice update

* Update weather.md

* add doc for new compliments(#3481) and support custom positions (#3518) (#254)

* add doc for new compliments(#3481) and support custom positions (#3518)

* fix typo

* update compliments, and module position info (#255)

* add doc for new compliments(#3481) and support custom positions (#3518)

* fix typo

* Added docs for new notification `MODULE_DOM_UPDATED` (#262)

* Bump send and express (#260)

Bumps [send](https://github.com/pillarjs/send) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.18.0...0.19.0)

Updates `express` from 4.20.0 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.20.0...4.21.0)

---
updated-dependencies:
- dependency-name: send
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added docs for new notification - . Fixes #261

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Windows section and add Wayland section (#265)

According to the changes in PR MagicMirrorOrg/MagicMirror#3594.

* add clarification for nextDaysRelative and showEndsOnlyWithDuration, … (#268)

* add clarification for nextDaysRelative and showEndsOnlyWithDuration, only apply to full day events

* add emphasis for PREVENT on showEndsOnlyWithDuration

* electron-rebuild -> @electron/rebuild (#271)

electron-rebuild has been deprecated.

* update doc for #3630 (#273)

* fix typos, add doc for calendar FullDateEnd format usage, add new env for fetch timeout (#277)

* fix typos, add doc for calendar FullDateEnd format usage, add new env variable for fetch timeout

* bump deps

* lint docs

* fix typo

---------

Co-authored-by: veeck <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Ross Younger <[email protected]>
Co-authored-by: Bugsounet - Cédric <[email protected]>
Co-authored-by: Kristjan ESPERANTO <[email protected]>
Co-authored-by: WallysWellies <[email protected]>
Co-authored-by: jargordon <[email protected]>
Co-authored-by: Karsten Hassel <[email protected]>
Co-authored-by: sam detweiler <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: veeck <[email protected]>
@sdetweil sdetweil deleted the update branch January 2, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants