Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weathergov Weather Provider Doc Update #131

Closed
dWoolridge opened this issue Oct 6, 2022 · 2 comments
Closed

weathergov Weather Provider Doc Update #131

dWoolridge opened this issue Oct 6, 2022 · 2 comments

Comments

@dWoolridge
Copy link
Contributor

After a deep-dive into the weathergov.js weather provider script, I believe the documentation needs to be updated...

https://docs.magicmirror.builders/modules/weather.html#configuration-options

Under "Weather.gov options"

weathergov.js no longer uses the weatherEndpoint configuration setting as the docs suggest. This option should be deleted from the documentation.
@dWoolridge
Copy link
Contributor Author

PR #132 addresses this issue.

This was referenced Oct 6, 2022
Merged
Merged
khassel pushed a commit to MagicMirrorOrg/MagicMirror that referenced this issue Oct 24, 2022
@rejas
Use metric units internally in all weatherproviders (#2849)
2d3940a 
So finally I think this refactorin is ready to be reviewed :-)

DONE:
- [x] Removed all conversion functions for wind and temperature from
specific weatherproviders
- [x] Use internally only metric units: celsius for temperature, meters
per seconds for wind
- [x] Convert temp and wind into the configured units when displaying
data on the UI
- [x] look how beaufort calculation uses metrics, added knots as new
windunit
- [x] add more e2e tests 

Checked providers:
- [x] Darksky
- [x] EnvCanada
- [x] OpenWeatherMap
- [x] SMHI provider 
- [x] UK Met Office
- [x] UK Met Office DataHub
- [x] WeatherBit
- [x] WeatherFlow
- [x] WeatherGov

TODO in different tickets:
- check weatherproviders for usage of weatherEndpoint (as seen in
MagicMirrorOrg/MagicMirror-Documentation#131) -> see
#2926
- cleanup precipations -> #2953

Co-authored-by: veeck <[email protected]>
@khassel
Copy link
Collaborator

khassel commented Jan 12, 2023

fix already merged so closing this.

@khassel khassel closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dWoolridge @khassel