Use outputs instead of env to pass data between steps

Mafalda-SFU · Jan 25, 2024 · 0eb71cd · 0eb71cd
1 parent 91fb69c
commit 0eb71cd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -75,6 +75,7 @@ jobs:
           fi
 
       - name: Code coverage
+        id: codeCoverage
         run: |
           if npm list jest >/dev/null 2>&1; then
             export CODE_COVERAGE=$( \
@@ -89,7 +90,7 @@ jobs:
             )
           fi
 
-          echo "codeCoverage=$CODE_COVERAGE" >> $GITHUB_ENV
+          echo "codeCoverage=$CODE_COVERAGE" >> $GITHUB_OUTPUT
           echo "### Code coverage: ${CODE_COVERAGE}%" >> $GITHUB_STEP_SUMMARY
 
       # Code coverage badge
@@ -101,7 +102,7 @@ jobs:
           gistID: ${{ inputs.code-coverage_gistID }}
           label: Coverage
           maxColorRange: 90
-          message: ${{ env.codeCoverage }}%
+          message: ${{ steps.codeCoverage.outputs.codeCoverage }}%
           minColorRange: 50
           namedLogo: Jest
-          valColorRange: ${{ env.codeCoverage }}
+          valColorRange: ${{ steps.codeCoverage.outputs.codeCoverage }}
diff --git a/.github/workflows/schedule.yml b/.github/workflows/schedule.yml
@@ -265,10 +265,11 @@ jobs:
       # Docs coverage
       - run: npm run docs:coverage
       - name: Docs coverage
+        id: docsCoverage
         run: |
           export DOCS_COVERAGE=$(cat doc-coverage/docCoverageReport.json | jq .jsdocCoverage.coveragePercent)
 
-          echo "docsCoverage=$DOCS_COVERAGE" >> $GITHUB_ENV
+          echo "docsCoverage=$DOCS_COVERAGE" >> $GITHUB_OUTPUT
           echo "### Docs coverage: ${DOCS_COVERAGE}%" >> $GITHUB_STEP_SUMMARY
 
       - name: Docs coverage badge
@@ -279,10 +280,10 @@ jobs:
           gistID: ${{ inputs.docs-coverage_gistID }}
           label: Docs coverage
           maxColorRange: 90
-          message: ${{ env.docsCoverage }}%
+          message: ${{ steps.docsCoverage.outcome.docsCoverage }}%
           minColorRange: 50
           namedLogo: readdotcv
-          valColorRange: ${{ env.docsCoverage }}
+          valColorRange: ${{ steps.docsCoverage.outcome.docsCoverage }}
 
 
   #