package update, add missing dependency chardet #75
Conversation
|
If these changes were merged, would it not cause a |
| - python: '3.9' | ||
| script: python3 -m tox -e py39 -- --cov-report=xml |
Pipfile
Outdated
| six = "~=1.12" | ||
| typing = {markers = "python_version<'3.7'", version = "~=3.7"} | ||
| pipfile = "*" | ||
| black = {markers = "python_version>='3.6'",version = "==21.9b0"} |
There was a problem hiding this comment.
Why not leave black unpinned here?
| black = {markers = "python_version>='3.6'",version = "==21.9b0"} | |
| black = {markers = "python_version>='3.6'", version="*"} |
Pinning It in the dev extras makes more sense to me
There was a problem hiding this comment.
One thing I've noticed with black, with is quite frustrating, is that it cannot be unpinned without causing other problems. Pipenv will refuse to install it as a "pre-release" without adding the additional flag. This long traceback can be a bit off-putting for some users. Though easily resolved it could also break any scripts that use Pipenv and do not include this flag.
There was a problem hiding this comment.
Yup I was able to confirm.
Additional information:
- issue new 'pre' syntax in Pipfile pypa/pipenv#1760 has been open for a few years now
- PR PEEP-007: Accepting pre-releases for specific packages pypa/pipenv#4607 was opened early this year, but I'm unsure of its status
I'm interested if it's feasible to remove black as a minimal dependency. It seems like we could provide it as an extra in one way or another
Pipfile
Outdated
| colorama = "*" | ||
| packaging = "*" | ||
| requirementslib = "*" | ||
| vistir = "*" | ||
| autopep8 = "*" | ||
| six = "*" | ||
| typing = "*" | ||
| chardet = "*" |
There was a problem hiding this comment.
Where you able to check if any of these packages may have been pinned for a reason?
still needs rules to run on scheduled/manual triggers Signed-off-by: Bryant Finney <[email protected]>
Signed-off-by: Bryant Finney <[email protected]>
Signed-off-by: Bryant Finney <[email protected]>
|
oops, #75 in the commit messages is actually referring to #75 in my GitLab fork haha |
currently only installs `pyenv` and Python versions Signed-off-by: Bryant Finney <[email protected]>
Signed-off-by: Bryant Finney <[email protected]>
Signed-off-by: Bryant Finney <[email protected]>
Signed-off-by: Bryant Finney <[email protected]>
# Conflicts: # Pipfile # Pipfile.lock # setup.py
|
The master branch now adds py |
|
I just checked and do find |
|
@Madoshakalaka I definitely version .idea, and keep this in This explains more, from Jetbrains: Not sure about the |
|
@jshwi thanks, that makes sense. I learned more about .idea files despite being a 5 year intellij user :) |
|
@Madoshakalaka Oh I had another read, here's what they say about dictionaries:
Funny, sometimes the file gets created for me, sometimes it doesn't |
No description provided.