Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change Types #13

Closed
dfeinberg5 opened this issue Nov 25, 2017 · 2 comments
Closed

Can't change Types #13

dfeinberg5 opened this issue Nov 25, 2017 · 2 comments
Labels

Comments

@dfeinberg5
Copy link

The types prop doesn't seem to work.

The default address works fine, but when you change it to anything else the autocomplete stops working with no errors.

@MadimetjaShika
Copy link
Owner

Hi there, thanks for reporting this. I'll look into it this coming weekend. You're welcome to submit a PR if you need the fix urgently.

MadimetjaShika added a commit that referenced this issue Dec 17, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MadimetjaShika
Copy link
Owner

Hi @dfeinberg5. I've published a pre-release [email protected]. This should resolve the issue you noted. I noticed two problems with this;

  • The 'city' and 'region' types weren't working on the example, and this was because of a typo. The SDK expects an array for all the types.
  • The prop was not reactive, and therefore the SDK would not get updated with the changed. This is now fixed.

Please check it out and let me know if all's good. This is also updated on the live example.

In the meantime i'm going to close the issue. Feel free to re-open if the problem still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants