Refactored BottleneckLowestPoint calculation #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reused the GetSlopeDirection function to figure out the direction vector the bottleneck plane was sloping towards.
Using this and the position of the bottleneck and the radius of the bottleneck I projected a position along the slope direction
You can see the yellow Debug.Line() always points to the lowest point on the bottleneck plane
https://gyazo.com/8c758804ec17321f9dd7fdcb904b3b65
The performance improvements are pretty good too, I tested by spawning 64 infinite liquid bottles angled so the function is called.
It reduces the GC allocation to 0B and the function self ms from ~2.8ms to < 0.1ms
https://i.imgur.com/C0LJNh1.png