-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add loongarch64 platform support #183
Conversation
# https://github.com/loong64/buildwheel/actions/runs/12577757574/job/35055581474
python3.11 -m scipy_openblas32
OpenBLAS using 'OpenBLAS 0.3.28 DYNAMIC_ARCH NO_AFFINITY loongson3r5 MAX_THREADS=64'
# https://github.com/loong64/buildwheel/actions/runs/12577757574/job/35055581563
python3.11 -m scipy_openblas64
OpenBLAS using 'OpenBLAS 0.3.28 USE64BITINT DYNAMIC_ARCH NO_AFFINITY loongson3r5 MAX_THREADS=64' |
~I don't understand the relevance of your comment about Does PyPI support uploading loongarch wheels? ~ Ahh, I see. There is a private registry of loongarch packages at https://gitlab.com/loong64/pypi/-/packages/. |
I am not sure how this will work. It will upload packages to https://anaconda.org/scientific-python-nightly-wheels, then how will users be able to download them? I think it would be worth putting some effort into getting this platform recognized, as discussed in https://discuss.python.org/t/pypi-supports-loongarchs-wheel-what-should-we-do/26253 before moving further forward. |
Thank you for your reply. |
In order to test the code you added, you will need to enable a loongarch64 job. You can add it like the aarch64 ones which also run in a qemu docker openblas-libs/.github/workflows/posix.yml Lines 60 to 72 in 0532c11
|
Alright, I have added loongarch64 builds to GitHub Actions, However, this will add additional build overhead. My initial thought was to have the loong64 organization handle the builds and hosting. |
That seemed quite reasonable to me, and less work than adding CI here. But happy with merging this either way, @mattip is the main maintainer here so whatever he thinks is best. |
I see two choices: either we accept changes for loongarch64 in Truthfully, I would be happy if the loongarch64 organization put effort toward integrating with the "regular" infrastructure with a PEP to add that architecture to |
Thanks to the two administrators for their answers. Is it ok if we just add support for the loongarch64 architecture? |
Signed-off-by: 吴小白 <[email protected]>
Let's go with this for now. |
git describe --tags --abbrev=8
in OpenBLAS at theOPENBLAS_COMMIT