Swift dialog supportv2 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Patch Notes
- Changed version to 1.0.4
- Added variables to support SwiftDialog (path, command file)
- Added an array to contain all customizable SwiftDialog options. Should make it easy for admins to slot in their own messaging/icons/etc.
- Added new flags `--swiftdialog` or `-d` (I didn't use -s because thats typically used for silent/quiet mode)
- Added new functions:
- checkSwiftDialog: If `--swiftdialog` is used, but SwiftDialog is not yet installed, patchomator will use Installomator to install SwiftDialog prior to running other labels
- swiftDialogCommand: Allows us to send updates to the running dialog window
- swiftDialogWindow: Builds an array containing the "display name" of each label we're going to process
- CompleteSwiftDialog: Deletes the tmp command file, and enables the "OK" button so that the dialog can be dismissed.
- If `--write` and `--swiftdialog` are both selected, a simple progress bounce will show for the duration of the discovery process. Works well with `--yes` for automation along with user facing progress bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--swiftdialogor-d(I didn't use -s because thats typically used for silent/quiet mode)--swiftdialogis used, but SwiftDialog is not yet installed, patchomator will use Installomator to install SwiftDialog prior to running other labels