Container support for mercury #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth7
force-pushed
the
mercury_dev
branch
from
b872eab to
1ac99e4
Compare
siddharth7
force-pushed
the
users/sisi/mercury_container
branch
2 times, most recently
from
d8cefdf to
29a7e09
Compare
siddharth7
force-pushed
the
users/sisi/mercury_container
branch
from
29a7e09 to
140a676
Compare
siddharth7
commented
Dec 31, 2018
| @@ -35,9 +36,13 @@ public class AzureWorkloadPsBackupProvider : IPsBackupProvider | |||
| private const CmdletModel.RetentionDurationType defaultFileRetentionType = | |||
| CmdletModel.RetentionDurationType.Days; | |||
| private const int defaultFileRetentionCount = 30; | |||
siddharth7
commented
Dec 31, 2018
| vmContainer => string.Compare(vmContainer.Name.Split(';').Last(), | ||
| containerName, true) == 0); | ||
|
|
||
| if (unregisteredVmContainer != null) |
There was a problem hiding this comment.
add an appropriate else statement which says "container already registered" message
siddharth7
commented
Dec 31, 2018
| [Parameter(Mandatory = true, Position = 1, | ||
| HelpMessage = ParamHelpMsgs.Container.ResourceId)] | ||
| [ValidateNotNullOrEmpty] | ||
| public string ResourceId { get; set; } |
There was a problem hiding this comment.
rename property or add alias to enable piping
siddharth7
commented
Jan 2, 2019
| @@ -30,6 +30,7 @@ internal static class Container | |||
| public const string RegisteredContainer = "The recovery services backup container."; | |||
| public const string FriendlyName = "The name of the resource being managed by the" + | |||
| " Azure Backup service (for example: resource name of the VM)."; | |||
| public const string ResourceId = "Azure VM Id"; | |||
siddharth7
force-pushed
the
mercury_dev
branch
from
1ac99e4 to
c437ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule