forked from Azure/azure-powershell
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring RecoveryServices for merge. #358
Open
dragonfly91
wants to merge
683
commits into
azure-preview
Choose a base branch
from
rsmerge
base: azure-preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unts on getting PoolNodeCounts
Merge websites-preview branch for BUILD
Breaking changes to DataLakeAnalytics
Add Basic Sku and Tag to IotHub
Recorded snapshots tests again Regenerated Restore-AzureRmWebAppSnapshot and filled in help examples. Refactored RestoreAzureWebAppSnapshot cmdlet. ResourceGroup and Name parameters specify target app. Rewrote RestoreAzureRmWebAppSnapshot cmdlet help.
The $publicIP is added at the end of the script in the example. This should be removed.
Removed use of alias in example
Remove the unnecessary $publicIp in the example
…o resources-improvements # Conflicts: # tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv # tools/StaticAnalysis/Exceptions/SignatureIssues.csv
Add PS CmdLets for Express Route Circuit Connection Resource
Implement Get-AzureBatchPoolNodeCounts and Start-AzureBatchComputeNodeServiceLogUpload cmdlets
Update License.rtf
Fix and rerecord Aks test
Fix flaky ArgumentCompleter tests
[Azure Analysis Services] Enable associate/dissociate gateway with AS.
Fix null parameter for recurse in set-azurermstoreitemaclentry
Example fixes for `New-AzureRmStorageAccount`.
Fixed header, added description, added example.
Update Test-AzureRmDnsAvailability Help File
Updating examples for BGP service communities
Fixed the header in the file, Added a description and Synopsis
Added descriptions to multiple cmdlets here.
Fix Export-AzureRmDataLakeStoreChildItemProperties help file
Update Test-AzureRmTestDnsAvailability Help
Updating the changelog Updating references to RecoveryServices project. Fixing build Adding Backup.cs file Updating test targets Updating test targets Removing RS.Backup Tests Removing RecoveryServices.Backup module from config files Removing RecoveryServices.Backup.Test project Removing RecoveryServices.Backup from TestMappings.json Update TestMappings.json Restoring the psd1 files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThrough
parameter.Cmdlet Parameter Guidelines