Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring RecoveryServices for merge. #358

Open
wants to merge 683 commits into
base: azure-preview
Choose a base branch
from
Open

Conversation

dragonfly91
Copy link

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

ejarvi and others added 30 commits April 25, 2018 16:20
Merge websites-preview branch for BUILD
Breaking changes to DataLakeAnalytics
Recorded snapshots tests again

Regenerated Restore-AzureRmWebAppSnapshot and filled in help examples.

Refactored RestoreAzureWebAppSnapshot cmdlet. ResourceGroup and Name parameters specify target app.

Rewrote RestoreAzureRmWebAppSnapshot cmdlet help.
The $publicIP is added at the end of the script in the example. This should be removed.
Removed use of alias in example
Remove the unnecessary $publicIp in the example
…o resources-improvements

# Conflicts:
#	tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
#	tools/StaticAnalysis/Exceptions/SignatureIssues.csv
vladimir-shcherbakov and others added 29 commits May 10, 2018 14:32
Add PS CmdLets for Express Route Circuit Connection Resource
Implement Get-AzureBatchPoolNodeCounts and Start-AzureBatchComputeNodeServiceLogUpload cmdlets
Fix flaky ArgumentCompleter tests
[Azure Analysis Services] Enable associate/dissociate gateway with AS.
Fix null parameter for recurse in set-azurermstoreitemaclentry
Example fixes for `New-AzureRmStorageAccount`.
Fixed header, added description, added example.
Update Test-AzureRmDnsAvailability Help File
Updating examples for BGP service communities
Fixed the header in the file, Added a description and Synopsis
Added descriptions to multiple cmdlets here.
Fix Export-AzureRmDataLakeStoreChildItemProperties help file
Update Test-AzureRmTestDnsAvailability Help
Updating the changelog

Updating references to RecoveryServices project.

Fixing build

Adding Backup.cs file

Updating test targets

Updating test targets

Removing RS.Backup Tests

Removing RecoveryServices.Backup module from config files

Removing RecoveryServices.Backup.Test project

Removing RecoveryServices.Backup from TestMappings.json

Update TestMappings.json

Restoring the psd1 files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.