Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use mock environment variables in maa-dirs tests #366

Merged
merged 5 commits into from
Jan 18, 2025
Merged

Conversation

wangl-cc
Copy link
Member

Change environment variables is not thread-safe, use a mock struct to avoid conflict. Because rust support ZST, so in normal case, there should be no overhead.

Change environment variables is not thread-safe, use a mock struct to avoid conflict.
Because rust support ZST, so in normal case, there should be no overhead.
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.27%. Comparing base (7539f2f) to head (ae05cdc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   66.24%   66.27%   +0.02%     
==========================================
  Files          42       42              
  Lines        3623     3626       +3     
==========================================
+ Hits         2400     2403       +3     
  Misses       1223     1223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangl-cc wangl-cc merged commit c5cce8d into main Jan 18, 2025
18 checks passed
@wangl-cc wangl-cc deleted the test/mock branch January 18, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant