Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate smallest .coffee files & init TODO list #732

Merged
merged 30 commits into from
Jan 3, 2025
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Dec 28, 2024

See the coffee.TODO for the status. Let's break this down into multiple small PRs starting with this one that does the first steps to decaffeinate our codebase entirely, i.e. getting rid of .coffee files and replacing them with .js or .js.erb files.


As specificed in the mentioned TODO file:

Everywhere where I don't specify something in parentheses, I've manually checked
that the new new .js or .js.erb file is called (via console.log) and that it works.

so to save some time, I don't expect reviewers to test everything manually (it really takes quite some time to do this). Maybe just read carefully through the replacements, compare them and then go on. Double-check entries marked with ⚠️

Copy link
Collaborator

@f-buerckel f-buerckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.27%. Comparing base (da59363) to head (e480f08).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #732   +/-   ##
=======================================
  Coverage   54.27%   54.27%           
=======================================
  Files         170      170           
  Lines        7344     7344           
=======================================
  Hits         3986     3986           
  Misses       3358     3358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit 7de7f0f into dev Jan 3, 2025
4 checks passed
@Splines Splines deleted the coffee/remove branch January 3, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants