-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap5 #463
Merged
Merged
Bootstrap5 #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-dismiss="modal" to data-bs-dismiss="modal" fixed footer placement for devise views
Renamed .pl-* and .pr-* to .ps-* and .pe-*. Renamed .border-left and .border-right to .border-start and .border-end. Renamed .text-left and .text-right to .text-start and .text-end. Navbars now require a container within (to drastically simplify spacing requirements and CSS required).
Dropped form-specific layout classes for our grid system.
"form-checkbox" to "form-check" "badge badge-light" to "badge badge-light text-dark" started adding "form-label" to form-labels and removing "form-group"
"form-group" -> "mb-3"
fixed helpdesks, added popover js to "bootstrap_modal_turbolinks_fix.coffee"
modals some dropdowns navs collapsibles
accordion helpdesks
for a lot of select fields fixed a few helpdesks
fix media search form fix comment form-checks fix bg-gray buttons
Closed
Thanks for opening this PR ;) Will look into it soon. |
Codecov Report
@@ Coverage Diff @@
## mampf-next #463 +/- ##
==============================================
- Coverage 66.50% 66.48% -0.02%
==============================================
Files 311 311
Lines 9412 9417 +5
==============================================
+ Hits 6259 6261 +2
- Misses 3153 3156 +3
|
(referring to the CSS class names)
This file was already deleted in commit a0557b8 in mampf-next. However, due to unknown reasons, during a merge of mampf-next into this branch, I reintroduced the file [1]. This is why this commit deletes it again. [1] 843854f#diff-f971a7862ba60ddb68800528aa4209773ddb3622a1507a123b0afc5aa3271a98
Reason: see commit message in commit d0f6541
This change was actually done in [1] but somehow got reintroduced in this branch again, so we remove it here manually. [1] a0557b8#diff-6d58d1f5718d589c6e138b97441c26ea8caaa3e0973f7c2c73ba7a64d600aec7
fosterfarrell9
previously approved these changes
May 29, 2023
text-secondary (gray) instead of text-dark (black)
We replace its id by 'lecture-content-card' as this is the key used in the respective lectures.coffee file to add or remove the class 'col-xxxl-9'
(on login page)
fosterfarrell9
approved these changes
Jun 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Branch for upgrade from bootstrap 4 to bootstrap 5.
Official link for Bootstrap migration:
https://getbootstrap.com/docs/5.0/migration/
Generally tried to recreate behavior and look as it was in v4.
What still needs to be addressed:
The hack for bootstrap accordions, that we use in v4, is not yet removed in v5.
Thorough testing probably required again (last time was before a lot of fixes).
What has been changed:
Some of the details of the changes (taken from my local documentation):
Fixed issues as are outlined in basecamp: https://3.basecamp.com/3978947/buckets/7198402/todos/5678353440#__recording_5887260341
and more changes as are outlined in the official link for migrating v4 to v5.
To migrate an accordion:
change “card” to “accordion-item”
change “div class=”card-header clickable”” zu “button class=”accordion-button collapsed””
change “data-” to “data-bs-”
change “card-body” to “accordion-body”